-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix + upgrade LK parser and rename it #5934
Conversation
not really sure why the test is failing here, it's passing for me locally. I would appreciate if you could take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks for handling this!
Could the test error have anything to do with time zone settings? A difference of two hours is exactly the difference between Central European Summer Time, which I presume your PC is set to, and UTC. |
Could be it but I thought I made sure all date times where time zone aware and only used UTC. I'll have to double check though. |
Issue
The parser didn't use the new parser classes and where missing tests.
Description
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.