refactor: remove arrow from CA-BC parser #6185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the parser to use `datetime`. Parser functionality has not changed. - add `24` hour handling (midnight next day)
Upgrade the parser to use `datetime` which is a python buit-in. Parser functionality has not changed. - rename `datetime` variable to `parsed_datetime`
|
Seems like this also contains the changes from the CA-AB pr it would be great if you could remove those changes from this PR, then I'll give it a proper review but I don't think there is any problems with the CA-BC changes at first glance. |
smaspe
reviewed
Dec 11, 2023
Comment on lines
+86
to
+92
| except ValueError: | ||
| # Handle special case where hour is `24` | ||
| row[0] = row[0].replace(" 24", " 00") | ||
| date_time = datetime.strptime(row[0], "%m/%d/%Y %H").replace( | ||
| tzinfo=TIMEZONE | ||
| ) | ||
| date_time += timedelta(days=1) |
There was a problem hiding this comment.
Shouldn't there be a test to confirm that the 24 value is present and did cause the ValueError?
There was a problem hiding this comment.
Yes actually, but lemme refactor the whole code block so that we don't need the exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #6135
Description
Upgrade the parser to use
datetimewhich is a python buit-in. Parser functionality has not changed.datetimevariable toparsed_datetimePreview
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.