-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of arrow #6135
Comments
Hi @VIKTORVAV99 , I would like to work on this. |
Sure thing! We use arrow in a lot of places so just pick a parser/file and remove it. |
I've compiled the following list to keep track of all parsers that have been refactored and one's the have not. The command I used is: grep -El '(import arrow|arrow)' parsers/*.py
or the below to get files without arrow:
grep -L -E '(import arrow|arrow)' parsers/*.py Edit by @VIKTORVAV99: |
Hello, would like to help too! This is my first time contributing, started with the parser for my home country: #6246 |
Thats great, thanks! |
Hi, I have just created PR #6481 to remove usage of the |
Hallo! I was planning to start trying to remove usage of the |
I don't think anyone is working on that particular parser so go right ahead! And thanks! |
Thanks! |
I tried to start on CA_BC this evening, but ran into an issue in attempting an initial run test_parser. Here is the full output: I've tried all permutations of CA-BC with underscores and spaces, and still can't seem to find the key. The web app shows 'CA-BC', and the same zone key is listed multiple times in the parser code. |
@nboswell216 When running
|
Hi, just wondering if I can still contribute to this issue. I'm first time trying to contribute, very beginner level. Do I just need to change parser to date time object? Would it be possible to see any before fix version and after fix version? |
There are still a few parsers that need updating I think but if you want a before and after fix I would look at some of the merged PRs. There you should be able to see both the code before and after as well as the diff between the two. |
Thank you for clarifying! If no one is working on [parsers/IN.py], can I work on [parsers/IN.py]? Or is there any other suggested parser for beginner? :) |
@lin0110 Any parser will be good for a beginner. If you get stuck, check out how the conversion has been handled in other parsers, especially in the same region. No need to ask to work on any of the parsers for this issue - if you don't see any open PR for a parser, just go for it! |
Thank you guys for responding and encouraging me, I really appreciate it! I'm currently working on IN.py, but I'm encountering a ConnectTimeoutError while running 'poetry run test_parser IN'. How can I fix this so I can continue testing my code? |
Description
The built in datetime class is faster and less error prone than arrow so we should migrate to fully using datetime instead of arrow in our parsers.
This probably needs to be done in steps so it's easier to review as it can have a big impact on how parsers are structured.
Parsers:
The text was updated successfully, but these errors were encountered: