Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove arrow from CA-QC #6192

Merged
merged 3 commits into from
Dec 21, 2023
Merged

refactor: remove arrow from CA-QC #6192

merged 3 commits into from
Dec 21, 2023

Conversation

Barissa-Imran
Copy link
Contributor

Issue

#6135

Description

Remove arrow module from parser. maintained its functionality

  • replace arrow with datetime

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier --write . and poetry run format to format my changes.

@Barissa-Imran
refactor: remove arrow from CA-QC
b4a8db1 
- maintained parser functionality
@Barissa-Imran Barissa-Imran mentioned this pull request Nov 29, 2023
Open
95 tasks
@VIKTORVAV99 VIKTORVAV99 self-requested a review as a code owner November 30, 2023 16:22
VIKTORVAV99
VIKTORVAV99 reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things otherwise this looks good!

parsers/CA_QC.py Outdated Show resolved Hide resolved
parsers/CA_QC.py Outdated Show resolved Hide resolved
@VIKTORVAV99 VIKTORVAV99 self-requested a review December 11, 2023 17:39
VIKTORVAV99
VIKTORVAV99 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for doing this!

@github-actions github-actions bot added the python Pull requests that update Python code label Dec 21, 2023
@VIKTORVAV99 VIKTORVAV99 merged commit e42f65a into electricitymaps:master Dec 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

Assignees
No one assigned
Labels
parser python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Barissa-Imran @VIKTORVAV99