Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to cypress 13 #6223

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

ascodeasice
Copy link
Contributor

Issue

Closes #6089

Description

Migrate Cypress version from 12 to 13, I've checked the Migration Guide that nothing in the test code needs to be changed.

Preview

None

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier --write . and poetry run format to format my changes.

@github-actions github-actions bot added frontend 🎨 dependencies Pull requests that update a dependency file labels Dec 5, 2023
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review here, wanted to take the proper time to go over the migration documentation just to double check but it looks good to go!

Let's get this merged!

@VIKTORVAV99 VIKTORVAV99 merged commit 7ca48db into electricitymaps:master Dec 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend 🎨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to cypress 13
3 participants