-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capacity update] US + minor change to EIA capacity parser #6354
Conversation
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to include tests that validate the new capacity data and the changes made to the EIA parser. 🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
config/zones/US-FLA-HST.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually reallocated oil as gas because there is apparently only gas production from EIA parser
@VIKTORVAV99 i'm reviewing all the values now, will merge after. :) |
Don't forget to run prettier, otherwise it won't let you merge. Easiest way would be |
* US capacity data + update to parser * add rounding * some mode reallocation * manual reallocation FLA-HST * manual adjustmen * manual adjustment SW-PNM * prettier * update capacity model * format --------- Co-authored-by: Mathilde Daugy <mathilde.daugy@electricitymaps.com>
Issue
New capacity data needed to filter out flaky EIA parser data
Description
Update to EIA parser so that we have capacity for all production modes
Update US yaml files with capacity data from 2023-10-01
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.