PE parser: add unit tests and remove usage of arrow module #6481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to have full data
github-actions
bot
added
parser
python
VIKTORVAV99
reviewed
Feb 15, 2024
| "production": element["production"], | ||
| "source": element["source"], | ||
| "zoneKey": element["zoneKey"], | ||
| "sourceType": "measured", |
There was a problem hiding this comment.
Suggested change
| "sourceType": "measured", | |
| "sourceType": element["sourceType"].value, |
This just brings it in line with our other tests and makes it easy to update if we ever change this.
VIKTORVAV99
reviewed
Feb 15, 2024
There was a problem hiding this comment.
One thing we can do if we want to reduce the size of these are minifying the files, it should have no impact on the tests.
ghost
mentioned this pull request
|
Merging this as is right now as we have a follow up PR that converts it to use parser event lists as well. |
VIKTORVAV99
approved these changes
Feb 16, 2024
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6135
Description
This PR adds unit tests for the PE parser and removes usage of the
arrowmodule from the PE parser.Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.