Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UY): Sanitise UY parser #6506

Merged
merged 3 commits into from
Feb 22, 2024
Merged

fix(UY): Sanitise UY parser #6506

merged 3 commits into from
Feb 22, 2024

Conversation

pierresegonne
Copy link
Member

@pierresegonne pierresegonne commented Feb 22, 2024

Issue

We've been parsing production events where all modes are at 0 for UY. These events cause downstream issues as they are not flagged for estimation.

Description

  • Adopts parser validation for the fetch function in the UY parser.
  • Sets all production to null if all is 0

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Feb 22, 2024
Copy link
Member

@FelixDQ FelixDQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Soon we will probably handle this in the outlier detection pipeline instead, but this makes sense for now!

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but nothing major.

However I can't seem to run it and get this exception:

parsers.lib.exceptions.ParserException: UY.py Parser: Impossible to fetch data url from ADME

Is it working for you?

parsers/UY.py Show resolved Hide resolved
parsers/UY.py Show resolved Hide resolved
parsers/UY.py Outdated Show resolved Hide resolved
@pierresegonne
Copy link
Member Author

However I can't seem to run it and get this exception:

Same happened for me before / after the changes - I think the source is flaky right now. It works as expected if you provide a delayed timestamp (try yesterday)

@pierresegonne pierresegonne enabled auto-merge (squash) February 22, 2024 13:57
@pierresegonne pierresegonne merged commit 440db14 into master Feb 22, 2024
19 checks passed
@pierresegonne pierresegonne deleted the ps/sanitise_UY_parser branch February 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants