Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6135 Remove Arrow Usage from CA_AB #6559

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Issue 6135 Remove Arrow Usage from CA_AB #6559

merged 6 commits into from
Mar 20, 2024

Conversation

nboswell216
Copy link
Contributor

Issue #6135

Description

Removes usage of arrow from CA_AB parser, all datetimes are still timezone aware

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Mar 14, 2024
VIKTORVAV99
VIKTORVAV99 requested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR, there is a small error that needs to be fixed but otherwise things looks good.

parsers/CA_AB.py Outdated Show resolved Hide resolved
VIKTORVAV99
VIKTORVAV99 reviewed Mar 19, 2024
View reviewed changes
parsers/CA_AB.py Outdated Show resolved Hide resolved
VIKTORVAV99
VIKTORVAV99 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing it!

@VIKTORVAV99 VIKTORVAV99 merged commit 768d729 into electricitymaps:master Mar 20, 2024
20 checks passed
@VIKTORVAV99 VIKTORVAV99 mentioned this pull request Mar 20, 2024
Open
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

Assignees
No one assigned
Labels
parser python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nboswell216 @VIKTORVAV99