Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pa): upgrade PA parser with event classes #6610

Conversation

amv213
Copy link
Contributor

@amv213 amv213 commented Apr 1, 2024

Issue

#6011
#6135

Description

This PR upgrades the PA parser to use event classes, and drops usage of arrow in favour of the datetime library.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@amv213 amv213 requested a review from VIKTORVAV99 as a code owner April 1, 2024 07:30
@github-actions github-actions bot added parser python Pull requests that update Python code tests labels Apr 1, 2024
parsers/PA.py Show resolved Hide resolved
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) April 2, 2024 14:11
@VIKTORVAV99 VIKTORVAV99 merged commit 41d3c8a into electricitymaps:master Apr 2, 2024
19 checks passed
@amv213 amv213 deleted the amv213/upgrade-pa-parser-with-event-classes branch April 2, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants