refactor(ni): remove usage of arrow from NI parser #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
reviewed
Apr 2, 2024
| return datetime_datetime | ||
| def get_time_from_system_map(text: str) -> datetime: | ||
| # date format is: "'Información en Tiempo Real al 02/04/2024 05:57:40 AM'" | ||
| datetime_text = extract_text(text, "en Tiempo Real al ", "'") |
There was a problem hiding this comment.
Why did this datetime_text change?
There was a problem hiding this comment.
They seem to have changed the subtitle on their webpage sometime between 2023/06/02 and 2023/11/28 👀
but the arrow code wasn't failing because arrow.get() is apparently able to extract the date even if parsing the full html returned by extract_text not matching anything
There was a problem hiding this comment.
Man arrow is filled with crazy unexpected stuff!
I'm glad we are removing it!
VIKTORVAV99
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6135
Description
This PR removes the dependency on
arrowfrom the NI parser.Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.