Change "see issue #5613" to "see details" #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-see-more-details
VIKTORVAV99
approved these changes
Apr 11, 2024
| <a | ||
| className="inline-flex text-sm font-semibold text-black underline dark:text-white" | ||
| href={`https://github.com/electricitymaps/electricitymaps-contrib/issues/${outageData.issue}`} | ||
| > | ||
| <span className="pl-1 underline">issue #{outageData.issue}</span> | ||
| <span className="pl-1 underline">{t('estimation-card.outage-details')}</span> |
There was a problem hiding this comment.
Nice to get the whole string translatable as well!
|
Thanks for fixing it 👏 |
…to-see-more-details
tonypls
reviewed
Apr 15, 2024
Wouldn't it be weird if the message is in english and then it says see details in German? @tonypls |
silkeholmebonnen
deleted the
silkebonnen/avo-171-change-see-issue-5613-to-see-more-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
AVO-171
Description
This PR changes the outage message so it says "see details" instead of "see issue #5613".
I thought "see details" was more correct than "see more details", but I can change it if you don't agree.
Preview
This picture is a mock since there are no outages at the moment (as far as I can tell).
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.