-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "see issue #5613" to "see details" #6657
Merged
silkeholmebonnen
merged 6 commits into
master
from
silkebonnen/avo-171-change-see-issue-5613-to-see-more-details
Apr 15, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70f4c26
change to see details and add stories to EstimationCard
silkeholmebonnen 1338120
fix
silkeholmebonnen c429145
Merge branch 'master' into silkebonnen/avo-171-change-see-issue-5613-…
silkeholmebonnen 48c5d33
fix
silkeholmebonnen 03e8ff1
fix
silkeholmebonnen 3d8e6e1
Merge branch 'master' into silkebonnen/avo-171-change-see-issue-5613-…
silkeholmebonnen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | ||
import { I18nextProvider } from 'react-i18next'; | ||
import i18n from 'translation/i18n'; | ||
|
||
import EstimationCard from './EstimationCard'; | ||
|
||
const meta: Meta<typeof EstimationCard> = { | ||
title: 'EstimationCard', | ||
component: EstimationCard, | ||
}; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof EstimationCard>; | ||
const instance: { message: string; issue: string } = { | ||
message: 'Some outage message.', | ||
issue: '5613', | ||
}; | ||
const queryClient = new QueryClient(); | ||
|
||
export const All: Story = { | ||
render: () => ( | ||
<div className="space-y-2"> | ||
<I18nextProvider i18n={i18n}> | ||
<QueryClientProvider client={queryClient}> | ||
<EstimationCard cardType="outage" outageMessage={instance} /> | ||
|
||
<EstimationCard cardType="estimated" outageMessage={instance} /> | ||
|
||
<EstimationCard | ||
cardType="estimated" | ||
outageMessage={instance} | ||
estimationMethod="estimated_mode_breakdown" | ||
/> | ||
|
||
<EstimationCard | ||
cardType="aggregated" | ||
outageMessage={instance} | ||
estimatedPercentage={20} | ||
/> | ||
|
||
<EstimationCard cardType="aggregated" outageMessage={instance} /> | ||
</QueryClientProvider> | ||
</I18nextProvider> | ||
</div> | ||
), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to get the whole string translatable as well!