Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the way our codebase makes use of
shelljs
library throughoutern
modules.Here is what this PR contains :
Relocate
shelljs
insideern-util
so that only one instance of it gets used in the process.Instead of importing
shelljs
as before through :import shell from 'shelljs'
the new way to retrieve the process wide instance is now
import { shell } from 'ern-util'
Configure instance of
sheljs
inern-local-cli
entryfatal = true
This will make
shelljs
throw an error if a command is failing (before we were usingthrowIfShellCommandFail
util function. This is not needed anymore all code has been cleanup accordingly part of this PR).verbose = logLevel === 'debug' || logLevel === 'trace'
This will make
shelljs
log every command line it is executing, only when platform log level is set todebug
ortrace
(before we were directly doinglog.debug
of the command line in some cases. This is not needed anymore all code has been cleanup accordingly part of this PR)Removes all dependencies on
shelljs
module fromern-
modules, as the dependency is not directly needed by the modules (they now consumeshell
fromern-util
)