Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iOS plugin injection configuration directives #224

Merged
merged 4 commits into from
Oct 24, 2017

Conversation

belemaire
Copy link
Member

@belemaire belemaire commented Oct 24, 2017

  • Add new addFrameworkSearchPath directive
  • Improve existing addProject directive to allow adding a Framework project
  • Fix a couple of bugs in iOS container generator

=> Bumped version of xcode-ern to 1.0.1 which contain the code needed to support addProject improvement.

These changes were made to properly support referencing an external iOS project (with a Framework target) inside the Container, which was needed for proper build of Container with FacebookSDK for Walmart iOS app.

@krunalsshah krunalsshah merged commit 9698b9f into electrode-io:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants