Add publisher command #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepueg
force-pushed
the
add-publisher-command
branch
2 times, most recently
from
971427c
to
b462bae
Compare
belemaire
requested changes
Nov 29, 2017
docs/cli/cauldron/add/publisher.md
Outdated
| #### Syntax | ||
|
|
||
| ###### Maven publisher | ||
| `ern caundron add publisher --mavenUrl=<url>` |
docs/cli/cauldron/add/publisher.md
Outdated
| `ern caundron add publisher --mavenUrl=<url>` | ||
|
|
||
| ###### Github publisher | ||
| `ern caundron add publisher --githubUrl=<url>` |
| } else if (githubUrl) { | ||
| url = githubUrl | ||
| } else { | ||
| throw new Error(`Please provide a publisher option (publisher --mavenUrl or --gitHubUrl)`) |
|
|
||
| import inquirer from 'inquirer' | ||
|
|
||
| export async function askUserToChooseAnOption (choices: Array<string>, message?: string): Promise<any> { |
There was a problem hiding this comment.
I like that. We have quite some calls to inquirer directly, it would be leaner to just reuse this one (and maybe other functions that will be addded to this util) where appropriate (through another "prompts" refactoring PR later on).
Makes it also more simple to replace inquirer lib with another one as every use of it will be centralized (also ease mocking for testing) 👍
krunalsshah
reviewed
Nov 29, 2017
docs/cli/cauldron/add/publisher.md
Outdated
| @@ -0,0 +1,28 @@ | |||
| ## `ern cauldron add publihser` | |||
krunalsshah
reviewed
Nov 29, 2017
docs/cli/cauldron/add/publisher.md
Outdated
|
|
||
| #### Remarks | ||
|
|
||
| * The `ern cauldron add publihser` command is mostly used once during the initial setup of cauldron since these links does not change frequently. |
krunalsshah
reviewed
Nov 29, 2017
| }) | ||
| } | ||
|
|
||
| exports.handler = async function ({ |
krunalsshah
reviewed
Nov 29, 2017
|
|
||
| log.debug(`Adding ${mavenUrl ? 'maven' : 'gitHub'}publisher: ${url}`) | ||
|
|
||
| if (!platform || (platform !== 'ios' && platform !== 'android')) { |
There was a problem hiding this comment.
Typically ios is written as iOS , comparing platform.toLowerCase() could be a consideration? that would leave the users options to remain case agnostic , so for android.
deepueg
force-pushed
the
add-publisher-command
branch
from
b462bae
to
7c14141
Compare
|
@belemaire @krunalsshah Thanks for the review. PR updated with requested changes. |
belemaire
approved these changes
Nov 29, 2017
…aven and GitHub publisher entry in cauldron.
deepueg
force-pushed
the
add-publisher-command
branch
from
7c14141
to
5c042e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.