Skip to content

Commit

Permalink
chore: Node 20 update (#1997)
Browse files Browse the repository at this point in the history
* chore: add Node 20 runtime to rush config

* chore: update rush version to support node 20 and remove node14 cli

---------

Co-authored-by: smuthya <srinath.reddy.muthyala@walmart.com>
  • Loading branch information
smuthya and srinathm85 committed Jan 8, 2024
1 parent bdf6691 commit 54d99aa
Show file tree
Hide file tree
Showing 6 changed files with 61 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion common/scripts/install-run-rush-pnpm.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion common/scripts/install-run-rush.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common/scripts/install-run-rushx.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 54 additions & 16 deletions common/scripts/install-run.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rush.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* path segment in the "$schema" field for all your Rush config files. This will ensure
* correct error-underlining and tab-completion for editors such as VS Code.
*/
"rushVersion": "5.101.1",
"rushVersion": "5.112.2",

/**
* The next field selects which package manager should be installed and determines its version.
Expand All @@ -42,7 +42,7 @@
* LTS schedule: https://nodejs.org/en/about/releases/
* LTS versions: https://nodejs.org/en/download/releases/
*/
"nodeSupportedVersionRange": ">=14.15.0 <15.0.0 || >=16.13.0 <17.0.0 || >=18.15.0 <19.0.0",
"nodeSupportedVersionRange": ">=16.13.0 <17.0.0 || >=18.15.0 <19.0.0 || >=20.9.0 <21.0.0",

/**
* Odd-numbered major versions of Node.js are experimental. Even-numbered releases
Expand Down

0 comments on commit 54d99aa

Please sign in to comment.