Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade jsdom to v21 for backward node version compatibility #2002

Closed
wants to merge 29 commits into from

Conversation

shubham2811
Copy link
Contributor

jsom v23(latest as of now) require minimum node 18 version which is breaking ci tests in case of node v14.So downgrading it to v21

Shubham sharma and others added 29 commits May 24, 2023 22:51
@shubham2811 shubham2811 requested a review from a team as a code owner January 5, 2024 04:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shubham2811
❌ Shubham sharma


Shubham sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shubham2811
Copy link
Contributor Author

Dropping node 14 support.Hence closing PR

@shubham2811 shubham2811 closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants