Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript upgrades #2011

Merged
merged 6 commits into from
May 16, 2024

Conversation

arunvishnun
Copy link
Contributor

@arunvishnun arunvishnun commented May 14, 2024

Summary

  • Typescript upgrade
  • Sample apps - react router upgrade to fix this issue

@arunvishnun arunvishnun marked this pull request as ready for review May 15, 2024 16:52
@arunvishnun arunvishnun requested a review from a team as a code owner May 15, 2024 16:52
@shubham2811 shubham2811 self-requested a review May 16, 2024 06:59
Copy link
Contributor

@shubham2811 shubham2811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunvishnun arunvishnun merged commit 29c302c into electrode-io:master May 16, 2024
3 checks passed
@arunvishnun arunvishnun deleted the feat/typescriptupgrade branch May 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Cannot find module './index' or its corresponding type declarations" in react-router-dom/server.d.ts
3 participants