v0.17.1 #2021
Merged
v0.17.1 #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're attempting to go to a single package.json structure, but the testcafe setup was still implicitly referencing app/node_modules. This adjusts testcafe so that it finds the electron browser (provided by testcafe-browser-provider-electron). Please double check this. I'm not familiar with testcafe, I just messed with paths until I got the tests passing.
* Remove app/node_modules from .gitignore In previous versions of electron-react-boilerplate, there was a 2-package.json structure where modules were installed in ./node_modules and ./app/node_modules. We've since migrated to a single package.json system, and there should only be ./node_modules present. If you notice ./app/node_modules (i.e. when running `git status`), you can safely delete the director ./app/node_modules. All dependencies are downloaded in ./node_modules now. History: #1854 * In .gitignore, update node_modules to /node_modules Details in comment: #1854 (comment) * Remove outdated references to app/node_modules Since we've moved to a single package.json structure, app/node_modules should no longer exist. * .gitignore all node_modules directories, not just the root one Defining /node_modules may inadvertently cause cause people using `electron-react-boilerplate` with subpackages to all of a sudden see their `node_modules` be included in unstaged files. Discussion: #1890 (comment)
* attempt fix linux path issues * remove RunTests script * temporarily allow snapshot updating on ci * change jest to run in verbose mode for ci debugging purposes * diff on ci to show snapshot changes * misc * temporarily allow failures on linux
* babel-upgrade * remove add-module-exports plugin * fix import issues with configStore * .babelrc -> babel.config.js * fix babel-preset-env useBuiltIns property * misc changes to linting annotaions
* add opencollective banner * babel-upgrade * remove add-module-exports plugin * .babelrc -> babel.config.js
* bump g++ version to 8.2 on travis ci linux * fix g++ package name * Update .travis.yml
* remove unnecessary api key from appveyor * Update appveyor.yml
* add initial autoupdate suport * fix publish config for electron-builder in package.json
vikr01
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn test-e2eand testcafe for single package.json structureyarn startscript