fix: resolve unstable unit test that is on latest mac (#7626)

electron-userland · Jun 24, 2023 · 16d1430 · 16d1430
1 parent 4652416
commit 16d1430
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 104 deletions.
diff --git a/test/fixtures/test-app-two-native-modules/app/package.json b/test/fixtures/test-app-two-native-modules/app/package.json
@@ -4,8 +4,5 @@
   "version": "1.1.1",
   "dependencies": {
     "debug": "4.1.1"
-  },
-  "optionalDependencies": {
-    "node-mac-permissions": "^2.3.0"
   }
 }
diff --git a/test/snapshots/HoistedNodeModuleTest.js.snap b/test/snapshots/HoistedNodeModuleTest.js.snap
@@ -188,37 +188,37 @@ Object {
         "debug": Object {
           "files": Object {
             "LICENSE": Object {
-              "offset": "3546",
+              "offset": "3476",
               "size": 1107,
             },
             "dist": Object {
               "files": Object {
                 "debug.js": Object {
-                  "offset": "22150",
+                  "offset": "22080",
                   "size": 27572,
                 },
               },
             },
             "package.json": Object {
-              "offset": "4653",
+              "offset": "4583",
               "size": 947,
             },
             "src": Object {
               "files": Object {
                 "browser.js": Object {
-                  "offset": "5600",
+                  "offset": "5530",
                   "size": 5831,
                 },
                 "common.js": Object {
-                  "offset": "11431",
+                  "offset": "11361",
                   "size": 5930,
                 },
                 "index.js": Object {
-                  "offset": "17361",
+                  "offset": "17291",
                   "size": 314,
                 },
                 "node.js": Object {
-                  "offset": "17675",
+                  "offset": "17605",
                   "size": 4475,
                 },
               },
@@ -228,15 +228,15 @@ Object {
         "ms": Object {
           "files": Object {
             "index.js": Object {
-              "offset": "49722",
+              "offset": "49652",
               "size": 3024,
             },
             "license.md": Object {
-              "offset": "52746",
+              "offset": "52676",
               "size": 1079,
             },
             "package.json": Object {
-              "offset": "53825",
+              "offset": "53755",
               "size": 497,
             },
           },
@@ -245,7 +245,7 @@ Object {
     },
     "package.json": Object {
       "offset": "3342",
-      "size": 204,
+      "size": 134,
     },
   },
 }

diff --git a/test/snapshots/mac/macPackagerTest.js.snap b/test/snapshots/mac/macPackagerTest.js.snap
@@ -527,50 +527,6 @@ Object {
             },
           },
         },
-        "node-mac-permissions": Object {
-          "files": Object {
-            ".prettierrc": Object {
-              "size": "<size>",
-              "unpacked": true,
-            },
-            "LICENSE": Object {
-              "size": "<size>",
-              "unpacked": true,
-            },
-            "build": Object {
-              "files": Object {
-                "Release": Object {
-                  "files": Object {
-                    "permissions.node": Object {
-                      "size": "<size>",
-                      "unpacked": true,
-                    },
-                  },
-                },
-                "node_gyp_bins": Object {
-                  "files": Object {
-                    "python3": Object {
-                      "size": "<size>",
-                      "unpacked": true,
-                    },
-                  },
-                },
-              },
-            },
-            "index.js": Object {
-              "size": "<size>",
-              "unpacked": true,
-            },
-            "package.json": Object {
-              "size": "<size>",
-              "unpacked": true,
-            },
-            "permissions.mm": Object {
-              "size": "<size>",
-              "unpacked": true,
-            },
-          },
-        },
       },
     },
     "package.json": Object {
@@ -584,51 +540,5 @@ exports[`yarn two package.json w/ native module 4`] = `
 Array [
   "app.asar",
   "electron.icns",
-  "app.asar.unpacked/node_modules/node-mac-permissions/LICENSE",
-  "app.asar.unpacked/node_modules/node-mac-permissions/index.js",
-  Object {
-    "content": "{
-  \\"name\\": \\"node-mac-permissions\\",
-  \\"version\\": \\"2.3.0\\",
-  \\"description\\": \\"A native node module to manage system permissions on macOS\\",
-  \\"main\\": \\"index.js\\",
-  \\"types\\": \\"index.d.ts\\",
-  \\"repository\\": {
-    \\"type\\": \\"git\\",
-    \\"url\\": \\"git+https://github.com/codebytere/node-mac-permissions.git\\"
-  },
-  \\"author\\": \\"Shelley Vohr <shelley.vohr@gmail.com>\\",
-  \\"license\\": \\"MIT\\",
-  \\"homepage\\": \\"https://github.com/codebytere/node-mac-permissions#readme\\",
-  \\"dependencies\\": {
-    \\"bindings\\": \\"^1.5.0\\",
-    \\"node-addon-api\\": \\"^3.0.2\\"
-  },
-  \\"devDependencies\\": {
-    \\"chai\\": \\"^4.3.6\\",
-    \\"clang-format\\": \\"1.8.0\\",
-    \\"husky\\": \\"^8.0.1\\",
-    \\"lint-staged\\": \\"^12.4.1\\",
-    \\"mocha\\": \\"^10.0.0\\",
-    \\"node-gyp\\": \\"^9.0.0\\",
-    \\"prettier\\": \\"^2.6.2\\"
-  },
-  \\"lint-staged\\": {
-    \\"*.js\\": [
-      \\"prettier --write\\"
-    ],
-    \\"*.mm\\": [
-      \\"clang-format -i\\"
-    ]
-  },
-  \\"os\\": [
-    \\"darwin\\"
-  ]
-}",
-    "name": "app.asar.unpacked/node_modules/node-mac-permissions/package.json",
-  },
-  "app.asar.unpacked/node_modules/node-mac-permissions/permissions.mm",
-  "app.asar.unpacked/node_modules/node-mac-permissions/build/node_gyp_bins/python3",
-  "app.asar.unpacked/node_modules/node-mac-permissions/build/Release/permissions.node",
 ]
 `;