fix(mac): signing cert filter incorrectly selects certificates (#6094) (

#6101) (#6105) * fix(mac): Adding Developer ID Application entry for development signing when not mas (#6094) * fix(mac): Removing 3rd Party Mac Developer Application certificate selector (#6101)
electron-userland · Jul 28, 2021 · 4a177dc · UnsignedInt8 · Aug 3, 2021 · 4a177dc
1 parent 7e0a77a
commit 4a177dc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/great-pumas-trade.md b/.changeset/great-pumas-trade.md
@@ -0,0 +1,6 @@
+---
+"app-builder-lib": patch
+---
+
+fix(mac): Adding Developer ID Application entry for development signing when building not a mas target. Fixes: #6094
+fix(mac): Removing 3rd Party Mac Developer Application certificate selector. Fixes: #6101
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -453,7 +453,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
 
 function getCertificateTypes(isMas: boolean, isDevelopment: boolean): CertType[] {
   if (isDevelopment) {
-    return ["Mac Developer", "Apple Development"]
+    return isMas ? ["Mac Developer", "Apple Development"] : ["Developer ID Application"]
   }
-  return isMas ? ["3rd Party Mac Developer Application", "Apple Distribution"] : ["Developer ID Application"]
+  return isMas ? ["Apple Distribution"] : ["Developer ID Application"]
 }