fix: signing of user-defined binaries on mac when resolved as relativ…

…e path (#6660)
electron-userland · Feb 22, 2022 · 4c6d154 · 4c6d154
1 parent 8db6c72
commit 4c6d154
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/eleven-rivers-confess.md b/.changeset/eleven-rivers-confess.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+Fix error thrown due to duplicated signing of user-defined binaries on mac when resolving relative path
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -243,17 +243,15 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
     let binaries = options.binaries || undefined
     if (binaries) {
       // Accept absolute paths for external binaries, else resolve relative paths from the artifact's app Contents path.
-      const userDefinedBinaries = await Promise.all(
+      binaries = await Promise.all(
         binaries.map(async destination => {
           if (await statOrNull(destination)) {
             return destination
           }
           return path.resolve(appPath, destination)
         })
       )
-      // Insert at front to prioritize signing. We still sort by depth next
-      binaries = userDefinedBinaries.concat(binaries)
-      log.info("Signing addtional user-defined binaries: " + JSON.stringify(userDefinedBinaries, null, 1))
+      log.info("Signing addtional user-defined binaries: " + JSON.stringify(binaries, null, 1))
     }
 
     const signOptions: any = {