Skip to content

Commit

Permalink
fix(mac): don't notarize mas builds (#7838)
Browse files Browse the repository at this point in the history
  • Loading branch information
mifi committed Oct 25, 2023
1 parent 4c9b829 commit 87eae1c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/smooth-lies-thank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: don't notarize mas builds
4 changes: 3 additions & 1 deletion packages/app-builder-lib/src/macPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
await this.dispatchArtifactCreated(artifactPath, null, Arch.x64, this.computeSafeArtifactName(artifactName, "pkg", arch, true, this.platformSpecificBuildOptions.defaultArch))
}

await this.notarizeIfProvided(appPath)
if (!isMas) {

Check warning on line 334 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Replace `if·(!isMas)·{·` with `····if·(!isMas)·{`

Check warning on line 334 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest)

Replace `if·(!isMas)·{·` with `····if·(!isMas)·{`
await this.notarizeIfProvided(appPath)

Check warning on line 335 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Insert `···`

Check warning on line 335 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest)

Insert `···`
}

Check warning on line 336 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Insert `····`

Check warning on line 336 in packages/app-builder-lib/src/macPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest)

Insert `····`
return true
}

Expand Down

0 comments on commit 87eae1c

Please sign in to comment.