fix(nsis): Add allowServiceToInstall nsis option for update by window…

… service If window service needs to run installer for update, the installer must have admin previlege.
electron-userland · Apr 15, 2022 · c89caf9 · c89caf9
1 parent 85a3e55
commit c89caf9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/poor-windows-heal.md b/.changeset/poor-windows-heal.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+Set isAdminRightsRequired option true regardless of oneClick option
diff --git a/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts b/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts
@@ -159,9 +159,12 @@ export class NsisTarget extends Target {
         .join(", "),
     }
     const isPerMachine = options.perMachine === true
+    const allowServiceToInstall = options.allowServiceToInstall !== false
+
     if (!this.isPortable) {
       logFields.oneClick = oneClick
       logFields.perMachine = isPerMachine
+      logFields.allowServiceToInstall = allowServiceToInstall
     }
 
     await packager.info.callArtifactBuildStarted(
@@ -319,7 +322,7 @@ export class NsisTarget extends Target {
       updateInfo = await createBlockmap(installerPath, this, packager, safeArtifactName)
     }
 
-    if (updateInfo != null && isPerMachine && oneClick) {
+    if ((updateInfo != null && isPerMachine && oneClick) || allowServiceToInstall) {
       updateInfo.isAdminRightsRequired = true
     }
 

diff --git a/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts b/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts
@@ -86,6 +86,12 @@ export interface NsisOptions extends CommonNsisOptions, CommonWindowsInstallerCo
    */
   readonly allowToChangeInstallationDirectory?: boolean
 
+  /**
+   * *Whether to allow window servie to install for update.
+   * @default false
+   */
+  readonly allowServiceToInstall?: boolean
+
   /**
    * The path to installer icon, relative to the [build resources](/configuration/configuration#MetadataDirectories-buildResources) or to the project directory.
    * Defaults to `build/installerIcon.ico` or application icon.