revert: fix(mac): should normalize unicode strings from file system b…

…efore used in string compare (#4841) (#7905) This reverts commit 37a17f2.
electron-userland · Nov 29, 2023 · d1347a0 · d1347a0
1 parent 3973c66
commit d1347a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.changeset/nine-rings-bow.md b/.changeset/nine-rings-bow.md
@@ -0,0 +1,5 @@
+---
+"dmg-builder": patch
+---
+
+fix dmg build when productName or executableName contains Unicode
diff --git a/packages/dmg-builder/vendor/mac_alias/alias.py b/packages/dmg-builder/vendor/mac_alias/alias.py
@@ -10,7 +10,6 @@
 import os.path
 import stat
 import sys
-from unicodedata import normalize
 
 if sys.platform == 'darwin':
     from . import osx
@@ -390,10 +389,6 @@ def for_file(cls, path):
         st = osx.statfs(path)
         vol_path = st.f_mntonname
 
-        # File and folder names in HFS+ are normalized to a form similar to NFD.
-        # Must be normalized (NFD->NFC) before use to avoid unicode string comparison issues.
-        vol_path = normalize("NFC", vol_path.decode('utf-8')).encode('utf-8')
-
         # Grab its attributes
         attrs = [osx.ATTR_CMN_CRTIME,
                  osx.ATTR_VOL_NAME,