Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks in asarUnpack are not copied #1376

Closed
NTag opened this issue Mar 15, 2017 · 7 comments
Closed

Symlinks in asarUnpack are not copied #1376

NTag opened this issue Mar 15, 2017 · 7 comments
Labels

Comments

@NTag
Copy link

NTag commented Mar 15, 2017

  • Version: 15.2.0
  • Target: Linux x64

With the asarUnpack option, it is possible to specify directories. The symlinks in those will not be copied in the app.asar.unpack/ destination folder.

I think we can see here that only files are added to the array filesToUnpack, and that no symlink will be added to filesToUnpack.

@develar
Copy link
Member

develar commented Mar 15, 2017

Workaround: set asar to false.

@develar
Copy link
Member

develar commented Jan 31, 2018

I hope it is obsolete now.

@Lucaszw
Copy link

Lucaszw commented Feb 5, 2018

This issue (or at least a similar one) still appears to be occurring for me. I have a bunch of sibling packages, that are linked together via lerna bootstrap. When running electron-builder, the node_modules of the sibling packages are not installed causing some missing package errors.

lerna --version
2.5.1
electron-builder --version
19.56.0
npm --version
5.4.2
node --version
v8.2.1

@develar
Copy link
Member

develar commented Feb 6, 2018

@Lucaszw Is it possible to provide sample project?

@Lucaszw
Copy link

Lucaszw commented Feb 6, 2018

Np!

https://github.com/Lucaszw/lerna-electron-builder-sample

After running electron builder:
app/dist/win-ia32-unpacked/resources/app/node_modules does not include lodash or backbone (dependencies of packages/app's siblings).

Running the installer leads to the following error message:

capture

@Nantris
Copy link

Nantris commented Apr 29, 2018

Is there anything we can try to resolve this? I tried adding the relevant folders to asarUnpack, but no luck with that. In particular, I'm having an issue with Lovell's Sharp

Linux Mint 18.3 x64
Electron-builder 20.8.1
Node 8.11.1
npm 5.6.0

Thanks for all your hard work and any ideas you might have.

@sytolk
Copy link

sytolk commented Nov 19, 2021

This issue exist for Linux platform with electron-builder v22.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants