Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute paths to updater resources #1862

Closed
ccorcos opened this issue Jul 25, 2017 · 7 comments
Closed

Support absolute paths to updater resources #1862

ccorcos opened this issue Jul 25, 2017 · 7 comments

Comments

@ccorcos
Copy link

ccorcos commented Jul 25, 2017

  • Version:
"electron": "1.7.4",
"electron-builder": "19.13.0",
"electron-updater": "2.4.4",
  • Target: Mac and Windows

In a previous version of the electron-updater, the latest-mac.json file contained a fully qualified path to download the next application version, for example:

{
  "version": "0.1.12",
  "releaseDate": "2017-07-25T17:28:28.808Z",
  "url": "https://desktop-release.notion-static.com/Notion-0.1.12-mac.zip"
}

However the new latest-mac.yml and the old windows latest.yml do not provide a full url:

version: 0.1.12
releaseDate: '2017-07-25T17:28:28.820Z'
githubArtifactName: Notion-0.1.12-mac.zip
path: Notion-0.1.12-mac.zip
sha512: >-
  RlrpWxGYKbPKvs/ja8/J1ZoRJ3T1Xt0G0Ey9S3kh6/rDb1vgG2HbSSHRm9SJ7zIkW96IZB/kl5flxxPr7W/74g==

This is problematic for me because we moved S3 buckets and our new one sits behind cloudflare. The old mac applications were able to update, but the newer mac apps and all the windows apps were not able to make the transition over to the new bucket.

My point is, it would be really nice if we use fully qualified urls :)

@ccorcos
Copy link
Author

ccorcos commented Jul 25, 2017

Actually, I suppose I can just upload a new app to the old bucket which points to the new bucket...

@ccorcos ccorcos closed this as completed Jul 25, 2017
@develar develar reopened this Jul 27, 2017
@hengkx
Copy link

hengkx commented Jul 31, 2017

I hope too

@develar
Copy link
Member

develar commented Jul 31, 2017

Duplicates #1678 (actually, fixed for @ccorcos )

@develar
Copy link
Member

develar commented Jul 31, 2017

Please note — file is generated with relative URL, but you can change path to absolute URL if need.

@hengkx
Copy link

hengkx commented Jul 31, 2017

@develar Thanks

@liliakai
Copy link

liliakai commented Oct 9, 2017

Can we also have an option to generate absolute urls in latest.yml? It would be nice to avoid editing yml files between building and publishing.

@develar
Copy link
Member

develar commented Oct 9, 2017

@liliakai For what? Why your new version is not hosted on the same server where old version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants