New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all files in /app are packaged #1929
Comments
As a workaround, if I add |
dist it is output directory by default and, so, excluded. Please see options https://github.com/electron-userland/electron-builder/wiki/Options and configure directories.output to another value. |
So it excludes any subfolder in the output directory that matches the output directory's name? This seems nonsensical, is undocumented and should be considered a bug in my opinion. |
Any if such subfolder is not specified in the
No magic here. No way to check is some artifact part of your app or result of build. So, output directory is excluded but you still able to override it — add subfolder to |
Shouldn't everything in the application directory be the result of the build and be packaged up though? I suppose I just don't see why anything inside app (or whatever the application directory is set to in options) would be excluded for any reason. The only thing that this exclusion would help with is if someone was silly enough to set their output folder to be inside the application directory. Either way, I'm glad to have a workaround I can use. Thanks for your consideration of this in any case :) |
|
Please set env |
Perhaps there's some miscommunication here due to confusion with the directory structure. Here are all the relevant directories after the app has been built and packaged in one image that should make it easier to understand: Here's the debug log you requested:
|
Bug: |
In the latest electron-builder, this is needed for subtle reasons: electron-userland/electron-builder#1929
In the latest electron-builder, this is needed for subtle reasons: electron-userland/electron-builder#1929
In the latest electron-builder, this is needed for subtle reasons: electron-userland/electron-builder#1929
In the latest electron-builder, this is needed for subtle reasons: electron-userland/electron-builder#1929
In the latest electron-builder, this is needed for subtle reasons: electron-userland/electron-builder#1929
As of version 20.18.0, this still seems to be a problem. Is there any reason the problem hasn't been fixed? Or has it been fixed in a more recent version and the issue accidentally left open? |
Any update on this issue? |
This is my app folder that should be being packaged:
/root/app
/root/app/dist
When I turn off asar packaging, and run the command
build --win --x64 --ia32 --dir
, it appears that not all files are packaged up. This is what thedist
directory looks like:/root/dist/win-unpacked/resources/app
So basically, it's missing the
dist
folder.Has something changed in electron-builder since v18.6.2 that may have caused this? Up until recently, this hasn't seemed to be a problem.
There's nothing crazy going on in the development/project package.json as far as I'm concerned, but here are the relevant parts in any case:
The text was updated successfully, but these errors were encountered: