Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic builds renaming not working on linux after 20.x version of builder #2615

Closed
verget opened this issue Feb 21, 2018 · 1 comment
Closed
Labels

Comments

@verget
Copy link

verget commented Feb 21, 2018

  • Version: 20.0.6
  • Target: linux

After update to 20.0.6 version build --linux --em.name=newName failed with error Unknown argument: em. When I tried --confign.name=newName - I had error configuration has an unknown property 'name', command --confign.productName=newName return no error but also didnt do anything with build name, it still marked as wrote in package.json productName field.

@develar
Copy link
Member

develar commented Feb 21, 2018

--config.extraMetadata.name

@develar develar closed this as completed Feb 21, 2018
gasi added a commit to signalapp/Signal-Desktop that referenced this issue Mar 1, 2018
gasi added a commit to signalapp/Signal-Desktop that referenced this issue Mar 2, 2018
* Upgrade to Electron 1.8.2 / Node.js 8.2.1

* Update CI Node.js versions

* Make `engines` top-level property

This was accidentally included under `build` which is disallowed
by `electron-builder`.

* Refactor notification updates

Allows easier debugging through variable inspection.

* Use `appId` for Application User Model ID

Recommended in:
electron/electron#10864 (comment)

* Update `spectron` to 3.8.0

* Bump `electron-builder` based dependencies

* Use `config.extraMetadata` instead of `em`

Prevents `Unknown argument: em` error.

See: electron-userland/electron-builder#2615

* Revert AUMID to be based on `packageJson.name`

In our build artifact `packageJson.build.appId` causes an NPE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants