Incorrect path resolution causes not work with yarn workspace

[Akimotorakiyu]

what happened

when use yarn workspaces, it cause InvalidConfigurationError: Cannot compute electron version from installed node modules - none of the possible electron modules are installed and version ("^9.0.5") is not fixed in project.

why

electron-builder/packages/app-builder-lib/src/electron/electronVersion.ts

Lines 16 to 52 in 7b335db

	export async function getElectronVersion(projectDir: string, config?: Configuration, projectMetadata: MetadataValue = new Lazy(() => orNullIfFileNotExist(readJson(path.join(projectDir, "package.json"))))): Promise<string> {
	if (config == null) {
	config = await getConfig(projectDir, null, null)
	}
	if (config.electronVersion != null) {
	return config.electronVersion
	}
	return await computeElectronVersion(projectDir, projectMetadata)
	}
	export async function getElectronVersionFromInstalled(projectDir: string) {
	for (const name of electronPackages) {
	try {
	return (await readJson(path.join(projectDir, "node_modules", name, "package.json"))).version
	}
	catch (e) {
	if (e.code !== "ENOENT") {
	log.warn({name, error: e}, `cannot read electron version package.json`)
	}
	}
	}
	return null
	}
	export async function getElectronPackage(projectDir: string) {
	for (const name of electronPackages) {
	try {
	return (await readJson(path.join(projectDir, "node_modules", name, "package.json")))
	}
	catch (e) {
	if (e.code !== "ENOENT") {
	log.warn({name, error: e}, `cannot find electron in package.json`)
	}
	}
	}
	return null
	}

// ...
return (await readJson(path.join(projectDir, "node_modules", name, "package.json"))).version
// ...

somet info

according to https://nodejs.org/dist/latest-v12.x/docs/api/modules.html#modules_require_resolve_request_options

it should be something like

// ...
return (await readJson(path.join(require.resolve(name), "..", "package.json")).version
// ...

but can't use require.resolve because of

electron-builder/tsconfig-base.json

Line 4 in 7b335db

"module": "esnext",

[Akimotorakiyu]

temp solution, work with build script
build.ts

// ...
import { getElectronVersion } from "./electronVersion";
async function build(){
  // ...
 const electronVersion = await getElectronVersion();

 builder.build({
      // ...
      config: {
        // ...
        electronVersion: electronVersion,
        // ...
    }
  })
}

build()

electronVersion.ts

const path = require.resolve("electron");
import { join } from "path";
import { readFile } from "fs-extra";

export async function getElectronVersion(): Promise<string> {
  const data = await readFile(join(path, "..", "package.json"));
  const version = JSON.parse(data.toString())?.version;
  console.log(version);
  return version;
}

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[nuochong]

me to

[jcc1997]

me too

[tajnymag]

This is still relevant as of 22.11.5