Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: libxcb-shape library is filtered in snapcraft.yaml by libxcb* wildcard #5205

Closed
cjp256 opened this issue Aug 6, 2020 · 1 comment
Closed

snap: libxcb-shape library is filtered in snapcraft.yaml by libxcb* wildcard #5205

cjp256 opened this issue Aug 6, 2020 · 1 comment
Labels
backlog

Comments

@cjp256
Copy link
Contributor

cjp256 commented Aug 6, 2020

  • Version:
    22.8.0

  • Electron Version:
    9.0.0

  • Electron Type (current, beta, nightly):
    current

  • Target:
    any

The snapcraft yaml filters out usr/lib/*/libxcb*. This causes libxcb-shape to be filtered out even when added as a stage-package.

This is poses a problem because it is not provided in the gnome 3.28 content snap (but is provided in the 3.34 snap FWIW). The regex can be split up be more accurate on what should be filtered out so applications requiring this library will package the necessary dependency.
cjp256 pushed a commit to cjp256/electron-builder that referenced this issue Aug 6, 2020
fix(snap): stricter filtering for xcb libraries (electron-userland#5205)
7f2b7bf 
Given the content available in the gnome 3-28 content snap:
```
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libX11-xcb.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libX11-xcb.so.1.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0.0.0
```

Replace the snapcraft.yaml's broad libxcb* filter with a set of more
targeted expressions for each of the provided libraries.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
cjp256 pushed a commit to cjp256/electron-builder that referenced this issue Aug 6, 2020
fix(snap): stricter filtering for xcb libraries (electron-userland#5205)
aa44c1b 
Given the content available in the gnome 3-28 content snap:
```
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0.0.0
```

Replace the snapcraft.yaml's broad libxcb* filter with a set of more
targeted expressions for each of the provided libraries.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
cjp256 pushed a commit to cjp256/electron-builder that referenced this issue Aug 12, 2020
fix(snap): stricter filtering for xcb libraries (electron-userland#5205)
48f7dd3 
Given the content available in the gnome 3-28 content snap:
```
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0.0.0
```

Replace the snapcraft.yaml's broad libxcb* filter with a set of more
targeted expressions for each of the provided libraries.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
develar pushed a commit that referenced this issue Sep 17, 2020
@cjp256
fix(snap): stricter filtering for xcb libraries (#5205) (#5206)
9164f4d 
Given the content available in the gnome 3-28 content snap:
```
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri2.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-dri3.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-glx.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-present.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-render.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-shm.so.0.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-sync.so.1.0.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0
/snap/gnome-3-28-1804/current/usr/lib/x86_64-linux-gnu/libxcb-xfixes.so.0.0.0
```

Replace the snapcraft.yaml's broad libxcb* filter with a set of more
targeted expressions for each of the provided libraries.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@stale
Copy link

stale bot commented Oct 7, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Oct 7, 2020
@stale stale bot closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjp256