Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmg): build under Big Sur is not possible if license file is used #5424

Merged
merged 1 commit into from Nov 28, 2020

Conversation

k2s
Copy link
Contributor

@k2s k2s commented Nov 17, 2020

Fixes #5319

In Big Sur the long time deprecated Rez and hdiutil unflatten tools were removed.
I am injecting DMG license with dmg-license package by keeping compatibility with TXT/RTF license and buttons files.

In this first version I keep all the old code.

@develar
Copy link
Member

develar commented Nov 28, 2020

Thanks a lot!

@develar develar merged commit 9e7b3c3 into electron-userland:master Nov 28, 2020
@mmaietta
Copy link
Collaborator

mmaietta commented Dec 2, 2020

Quick note: This PR forgot to update the yarn.lock and also broke master branch.

/Users/travis/build/electron-userland/electron-builder/packages/dmg-builder/src/dmgLicense.ts
  12:98  error  Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`.
- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.
- If you want a type meaning "any value", you probably want `unknown` instead  @typescript-eslint/ban-types
  37:9   error  'label' is never reassigned. Use 'const' instead                                                                                                                                                                                                                                                                  prefer-const
✖ 2 problems (2 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

@aabuhijleh
Copy link

Hi, is this released on the latest version on npm ?

I tested with 22.9.1 and I'm still getting this error hdiutil: unflatten: verb not recognized on Big Sur

@mmaietta
Copy link
Collaborator

Try latest 22.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build DMG with Big Sur (Xcode 12): hdiutil: unflatten: verb not recognized
4 participants