Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-builder-lib): bump @electron/universal to 1.2.1 #6750

Merged

Conversation

bradrees
Copy link
Contributor

Currently it cannot build an Electron 18 Universal (Mac) app:

Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/MainMenu.nib/keyedobjects-101300.nib"

Universal 1.2.1 has a fix for this, so bumping the version here too.

Currently it cannot build an Electron 18 Universal app
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2022

🦋 Changeset detected

Latest commit: 72bc351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for car-park-attendant-cleat-11576 failed.

Name Link
🔨 Latest commit 72bc351
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/624b4769ffc02600092f8d79

Copy link

@GeekCornerGH GeekCornerGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully working

@mmaietta mmaietta self-assigned this Apr 4, 2022
@mmaietta mmaietta changed the title fix (app-builder-lib): bump @electron/universal to 1.2.1 fix(app-builder-lib): bump @electron/universal to 1.2.1 Apr 4, 2022
@bradrees
Copy link
Contributor Author

bradrees commented Apr 5, 2022

If anyone is having this issue and needs a quick fix until this is merged, you can update your package.json like so:

  },
  "devDependencies": {
    "electron": "^18.0.0",
    "electron-builder": "^23.0.3",
    <other dependencies here>
  },
  "resolutions": {
    "@electron/universal": "^1.2.1"
  }
}

@medanat
Copy link

medanat commented Apr 5, 2022

If anyone is having this issue and needs a quick fix until this is merged, you can update your package.json like so:

  },
  "devDependencies": {
    "electron": "^18.0.0",
    "electron-builder": "^23.0.3",
    <other dependencies here>
  },
  "resolutions": {
    "@electron/universal": "^1.2.1"
  }
}
  "overrides": {
    "@electron/universal": "^1.2.1"
  }

for npm users

@mmaietta mmaietta merged commit 370f84b into electron-userland:master Apr 7, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Apr 7, 2022

Thank you for your contribution!

@github-actions github-actions bot mentioned this pull request Apr 7, 2022
csett86 added a commit to jitsi/jitsi-meet-electron that referenced this pull request Apr 27, 2022
Mostly chromium security updates, and not yet updating to electron 18 as that requires at least electron-builder 23.0.4 (due to electron-userland/electron-builder#6750), but electron-builder 23.0.4+ are not yet stable.

Signed-off-by: Christoph Settgast <csett86@web.de>
csett86 added a commit to jitsi/jitsi-meet-electron that referenced this pull request Jun 23, 2022
This is a prerequisite for universal mac builds with electron 18+
For details see electron-userland/electron-builder#6750
csett86 added a commit to jitsi/jitsi-meet-electron that referenced this pull request Jun 24, 2022
This is a prerequisite for universal mac builds with electron 18+
For details see electron-userland/electron-builder#6750
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this pull request Sep 1, 2023
Mostly chromium security updates, and not yet updating to electron 18 as that requires at least electron-builder 23.0.4 (due to electron-userland/electron-builder#6750), but electron-builder 23.0.4+ are not yet stable.

Signed-off-by: Christoph Settgast <csett86@web.de>
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this pull request Sep 1, 2023
This is a prerequisite for universal mac builds with electron 18+
For details see electron-userland/electron-builder#6750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants