Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to create universal mac build after update electron to v18.0.0 #6751

Closed
ocavue opened this issue Mar 29, 2022 · 5 comments
Closed

failed to create universal mac build after update electron to v18.0.0 #6751

ocavue opened this issue Mar 29, 2022 · 5 comments

Comments

@ocavue
Copy link

ocavue commented Mar 29, 2022

  • Electron-Builder Version: 22.14.13
  • Node Version: 16
  • Electron Version: 18.0.0
  • Electron Type (current, beta, nightly): current
  • Target: mac

After updating electron from v17.3.0 to v18.0.0, electron-builder raises the following error when I try to build a universal mac build:

• electron-builder  version=[22](https://github.com/ocavue/rino/runs/5741400411?check_suite_focus=true#step:6:22).14.13 os=20.6.0
  • loaded configuration  file=/Users/runner/work/rino/rino/packages/electron/electron-builder.js
  • packaging       platform=darwin arch=x64 electron=18.0.0 appOutDir=dist/mac-universal--x64
  • downloading     url=https://github.com/electron/electron/releases/download/v18.0.0/electron-v18.0.0-darwin-x64.zip size=82 MB parts=6
  • downloaded      url=https://github.com/electron/electron/releases/download/v18.0.0/electron-v18.0.0-darwin-x64.zip duration=1.089s
  • packaging       platform=darwin arch=arm64 electron=18.0.0 appOutDir=dist/mac-universal--arm64
  • downloading     url=https://github.com/electron/electron/releases/download/v18.0.0/electron-v18.0.0-darwin-arm64.zip size=84 MB parts=6
  • downloaded      url=https://github.com/electron/electron/releases/download/v18.0.0/electron-v18.0.0-darwin-arm64.zip duration=1.307s
  • packaging       platform=darwin arch=universal electron=18.0.0 appOutDir=dist/mac-universal
  ⨯ Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/MainMenu.nib/keyedobjects-101300.nib" did not  failedTask=build stackTrace=Error: Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/MainMenu.nib/keyedobjects-101300.nib" did not
    at exports.makeUniversalApp (/Users/runner/work/rino/rino/node_modules/.pnpm/@electron+universal@1.0.5/node_modules/@electron/universal/src/index.ts:107:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at MacPackager.doPack (/Users/runner/work/rino/rino/node_modules/.pnpm/app-builder-lib@22.14.13/node_modules/app-builder-lib/src/macPackager.ts:1[25](https://github.com/ocavue/rino/runs/5741400411?check_suite_focus=true#step:6:25):9)
    at MacPackager.pack (/Users/runner/work/rino/rino/node_modules/.pnpm/app-builder-lib@22.14.13/node_modules/app-builder-lib/src/macPackager.ts:177:7)
    at Packager.doBuild (/Users/runner/work/rino/rino/node_modules/.pnpm/app-builder-lib@22.14.13/node_modules/app-builder-lib/src/packager.ts:441:9)
    at Object.executeFinally (/Users/runner/work/rino/rino/node_modules/.pnpm/builder-util@22.14.13/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/runner/work/rino/rino/node_modules/.pnpm/app-builder-lib@22.14.13/node_modules/app-builder-lib/src/packager.ts:376:[31](https://github.com/ocavue/rino/runs/5741400411?check_suite_focus=true#step:6:31))
    at Packager.build (/Users/runner/work/rino/rino/node_modules/.pnpm/app-builder-lib@22.14.13/node_modules/app-builder-lib/src/packager.ts:[33](https://github.com/ocavue/rino/runs/5741400411?check_suite_focus=true#step:6:33)7:12)
    at Object.executeFinally (/Users/runner/work/rino/rino/node_modules/.pnpm/builder-util@22.14.13/node_modules/builder-util/src/promise.ts:12:14)

According to electron/electron#33267, we need to update @electron/universal to v1.2.1 to fix this issue.

@ocavue
Copy link
Author

ocavue commented Mar 29, 2022

Related PR: #6750

@mayfield
Copy link

Any known workarounds for this, or should I revert to electron v17 for now?

@ArmelChesnais
Copy link

@mayfield if you're using yarn, you can use resolutions in your package.json:

  "resolutions": {
    "@electron/universal": "^1.2.1"
  },

And install that package in your own devDependencies

"devDependencies": {
   [...]
   "@electron/universal": "^1.2.1",
   [...]

This will force all dependencies to use that version.
You will have to remove it once it's been addressed by electron-builder to avoid any weird behaviours in the future, but this should help in the meantime as a temporary band-aid.

@bjbk
Copy link

bjbk commented Apr 1, 2022

@ArmelChesnais Thanks for this reminder! I was able to upgrade to v18 and now universal build is successful. ✨
App · [SUCCESS] electron-builder built the app

GarboMuffin added a commit to TurboWarp/desktop that referenced this issue Apr 1, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Apr 9, 2022

Released in latest 23.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants