Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing @types dependencies for output d.ts files #7568

Merged
merged 3 commits into from May 5, 2023

Conversation

t3chguy
Copy link
Contributor

@t3chguy t3chguy commented May 5, 2023

Regressed by #7508
Similar to #4556
#4574 is the previous incarnation of this PR

Fixes failures like https://github.com/vector-im/element-desktop/actions/runs/4860501384/jobs/8664396114?pr=641

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

🦋 Changeset detected

Latest commit: 9fa02e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
app-builder-lib Patch
builder-util Patch
electron-publish Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 9fa02e7
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/645532787dc2dc0008818705
😎 Deploy Preview https://deploy-preview-7568--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@t3chguy t3chguy changed the title Fix missing @types dependencies for output d.ts files fix: missing @types dependencies for output d.ts files May 5, 2023
@mmaietta
Copy link
Collaborator

mmaietta commented May 5, 2023

Thank you for tackling this. Will get it merged asap.

@mmaietta
Copy link
Collaborator

mmaietta commented May 5, 2023

Hmmm can you run pnpm install again?

I'm seeing CI build errors

 ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the lockfile needs updates

@t3chguy
Copy link
Contributor Author

t3chguy commented May 5, 2023

 ~/W/electron-builder   t3chguy/@types  pnpm install                                                                                                                           Fri May  5 17:31:32 2023
Scope: all 14 workspace projects
 WARN  There are cyclic workspace dependencies: /Users/t3chguy/WebstormProjects/electron-builder/packages/app-builder-lib, /Users/t3chguy/WebstormProjects/electron-builder/packages/dmg-builder; /Users/t3chguy/WebstormProjects/electron-builder/packages/app-builder-lib, /Users/t3chguy/WebstormProjects/electron-builder/packages/dmg-builder, /Users/t3chguy/WebstormProjects/electron-builder/packages/app-builder-lib, /Users/t3chguy/WebstormProjects/electron-builder/packages/electron-builder-squirrel-windows
Lockfile is up to date, resolution step is skipped
Already up to date
. prepare$ husky install
│ husky - Git hooks installed
└─ Done in 251ms
Done in 1.5s

looks like it has nothing to do, it looks like pnpm i upgraded the lockfile from v5.4 to 6.0 and broke things

@t3chguy t3chguy closed this May 5, 2023
@t3chguy t3chguy reopened this May 5, 2023
@t3chguy
Copy link
Contributor Author

t3chguy commented May 5, 2023

Misclick, my bad. Tried again using pnpm 7 (had 8 installed previously)

@mmaietta mmaietta merged commit c9d20db into electron-userland:master May 5, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants