Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Include all DefinitelyTyped packages as dev dependencies #7508

Merged

Conversation

NoahAndrews
Copy link
Contributor

There were a good number of DefinitelyTyped packages in the non-dev dependencies.

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

🦋 Changeset detected

Latest commit: eefb2fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
builder-util Patch
electron-builder Patch
electron-publish Patch
electron-updater Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit eefb2fc
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6421f9a0ce10c3000803f87a
😎 Deploy Preview https://deploy-preview-7508--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NoahAndrews NoahAndrews changed the title Include all DefinitelyTyped packages as dev dependencies chore: Include all DefinitelyTyped packages as dev dependencies Mar 27, 2023
@NoahAndrews NoahAndrews changed the title chore: Include all DefinitelyTyped packages as dev dependencies chore(deps): Include all DefinitelyTyped packages as dev dependencies Mar 27, 2023
@mmaietta
Copy link
Collaborator

Thanks! Please consider running pnpm generate-changeset to add this changeset file to the auto-release build pipeline.

@mmaietta mmaietta merged commit d4c90b6 into electron-userland:master Mar 28, 2023
13 checks passed
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
@NoahAndrews NoahAndrews deleted the make-types-dev-dependencies branch March 29, 2023 05:28
@t3chguy
Copy link
Contributor

t3chguy commented Apr 18, 2023

With this change I am getting CI failures trying to update. https://github.com/vector-im/element-desktop/actions/runs/4734719714/jobs/8404026062?pr=641 - looks like the d.ts files are requiring the types which you've just removed.

@t3chguy
Copy link
Contributor

t3chguy commented May 5, 2023

This has regressed #4556 - some DefinitelyTyped packages being dependencies was intentional - see #4574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants