revert: fix(mac): should normalize unicode strings from file system before used in string compare

[jebibot]

This reverts commit 37a17f2 (#4841).

Since names are normalized to NFD as of #7901, normalizing them back to NFC leads to a similar error:

File "node_modules/dmg-builder/vendor/dmgbuild/core.py", line 290, in <module>
    build_dmg()
  File "node_modules/dmg-builder/vendor/dmgbuild/core.py", line 261, in build_dmg
    icvp['backgroundImageAlias'] = biplist.Data(alias.to_bytes())
                                                ^^^^^^^^^^^^^^^^
  File "node_modules/dmg-builder/vendor/mac_alias/alias.py", line 649, in to_bytes
    self._to_fd(b)
  File "node_modules/dmg-builder/vendor/mac_alias/alias.py", line 535, in _to_fd
    cnid_path = struct.pack('>%uI' % len(self.target.cnid_path),
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
struct.error: 'I' format requires 0 <= number <= 4294967295

The error ony occurs in:

• Darwin Mac-1701234016364.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Oct 4 23:55:28 PDT 2023; root:xnu-8020.240.18.704.15~1/RELEASE_X86_64 x86_64 (GitHub Actions macos-latest, https://github.com/jebibot/electron-test/actions/runs/7028916259/job/19125658541)
• Darwin Mac-1701233428287.local 22.6.0 Darwin Kernel Version 22.6.0: Fri Sep 15 13:39:52 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_X86_64 x86_64 (GitHub Actions macos-13, https://github.com/jebibot/electron-test/actions/runs/7028916259/job/19125658708)

but not in:

• Darwin MacBookPro.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64

It seems like a macOS < 14 issue or an x64 vs. arm64 issue so I couldn't catch it earlier. Sorry, I should've tested more.

This fix was also mentioned in #5977:

If I try the same exact string in NFD notation, the codesign works but later the dmg build process breaks. I am able to fix this by applying a patch-package modification basically reverting #4841.

Tested on: https://github.com/jebibot/electron-test/actions/runs/7028981048.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1e71eb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
dmg-builder	Patch
electron-builder	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	1e71eb1
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6566cd4e916b5200086606c5
😎 Deploy Preview	https://deploy-preview-7905--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.