Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update does not work on machines with Powershell version < 3 #1734

Conversation

MariaDima
Copy link
Contributor

Close #1732

@mention-bot
Copy link

@MariaDima, thanks for your PR! By analyzing the history of the files in this pull request, we identified @maczikasz, @AlienHoboken and @badams to be potential reviewers.

@MariaDima
Copy link
Contributor Author

MariaDima commented Jun 22, 2017

I was experimenting with ConvertTo-CSV command that is supported by powershell < 3.

It could be used to support Windows 7 users.
It sounds weird, but there is still an important group of people that still uses Windows 7.
However, the output is not good at all: It's more like a string, from which we need to extract data using either a regular expression or a substring logic (easier).

What's your thoughts on this?
The output could depend on the way the certificate was created (which options were provided during creation), but it could be an attempt to support more users before bypassing verification.
Or even try a verification without any nice error handling for these users.

@develar
Copy link
Member

develar commented Jun 22, 2017

Why not just check windows version? Got it. If user will upgrade to new version on win 7.

@develar
Copy link
Member

develar commented Jun 22, 2017

Thanks!

@develar develar closed this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants