Added electron 3(Node 10) support to nisis updater #3371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@develar 🙏 |
|
This is a crucial PR. All updates are failing atm with the new electron-builder |
|
Yea this is really a show-stopper bug. Entire module not working with electron 3. |
|
@timotheeguerin Thanks a lot. Sorry for delay. electron-updater 3.1.3 released. It is |
|
Looks to work great! Thanks. |
|
Whooo, thank you all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3367
Looks like that in node 10 (Electron 3 use node 10)
spawnis not throwing errors when the process fail to execute. This means the updater doesn't catch theEACCESerror emitted when installer need admin permissions.The fix will try to catch error both from node 8 and node 10 by listening to the error event for node 10 and using try catch for node 8. This should keep support for electron 2 while enabling electron 3.