Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: win custom sign should have same signature of doSign #4833

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

link89
Copy link
Contributor

@link89 link89 commented Apr 1, 2020

  • The win custom sign script should be able to use WinPackage as doSign does.
  • Export doSign method to allow users to wrap it in their script instead of rewrite whole code signing logic. For example, to just skip some files to sign.

@link89
Copy link
Contributor Author

link89 commented Apr 1, 2020

@develar Can you help to review and approve this?
We found that after upgrade from v20 to v22, all binary files under app.asar.unpacked are signed, which would break some third party SDK, like this one #3637. So we hope that electron-builder can have some easy way to skip some files to sign.

@develar develar merged commit f938de5 into electron-userland:master Apr 1, 2020
BusinessDuck pushed a commit to BusinessDuck/electron-builder that referenced this pull request Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants