Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing event-update-not-available in UpdaterEvents #5923

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

dkarski
Copy link
Contributor

@dkarski dkarski commented May 26, 2021

@mmaietta
Copy link
Collaborator

Can you manually update the snapshot test file here to match the new file size? The size seems to always change depending on what files commits add/remove content to the code (and I don't know why)

Snapshot name: `posix smart unpack 2`

- Snapshot  - 2
+ Received  + 2

@@ -956,14 +956,14 @@
              },
              "LICENSE": Object {
                "size": 1069,
              },
              "abi_registry.json": Object {
-               "size": 1884,
+               "size": 1885,
              },
              "index.js": Object {
-               "size": 6099,
+               "size": 6391,
              },
              "package.json": Object {
                "size": 547,
              },
              "scripts": Object {
    at verifySmartUnpack (/root/project/test/src/BuildTest.ts:344:51)
    at /root/project/test/src/helpers/packTester.ts:147:9
    at executeFinally (/root/project/packages/builder-util/src/promise.ts:12:14)
    at assertPack (/root/project/test/src/helpers/packTester.ts:117:3)

@mmaietta mmaietta self-assigned this May 29, 2021
@dkarski
Copy link
Contributor Author

dkarski commented May 31, 2021

Can you manually update the snapshot test file here to match the new file size?

Please do it for me, because I don't even have the project downloaded 🙈

@mmaietta
Copy link
Collaborator

mmaietta commented Jun 1, 2021

I've fixed the CI failure in another PR. Merging this one now

@mmaietta mmaietta merged commit dc359de into electron-userland:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants