fix: Windows update fails for custom paths that require admin rights

[hvuntokrul]

Proposed fix to the situation on Windows where an Electron is installed for all users of the machine e.g. into Program Files, but fails to update (installed app version is deleted but the update is never installed) due to failure to request admin rights.

node v12.16.2
npm v6.14.4

Current build.nsis settings in package.json:
{
"oneClick": false,
"allowToChangeInstallationDirectory": true,
"allowElevation": true,
...
}

[jmeinke]

I don't know for sure but I suppose there might be an error related to this PR:
After upgrading electron-builder to v22.11.11 and updater to the version 4.4.3 the elevated rights are being requested even if the app has been installed per-user into the standard path on Windows 10.

We'll downgrade electron-updater to version 4.3.10 in order to check, if this PR has introduced this unexpected behaviour. I'll add another post when we have the results.

[jmeinke]

@mmaietta I can confirm that this PR (electron-updater v4.4.3 as opposed to v4.3.10) will result in elevated rights being requested even for a per-user update via quitAndInstall -> should not. IMO this improvement introduces a regression and should be improved / fixed.

[hvuntokrul]

@jmeinke Thank you for your reply.
Could you please:

• tell if this behaviour has been reproduced on more than 1 machine;
• confirm that the user is in no way limited in their read/write rights;
• try to write out the exact steps to reproduce this behaviour?

Code review and our own testing did not confirm this bug nor any obvious reason for it to exist (the entire PR is basically just one file write/delete operation).

Thank you:)

[sandeep1995]

I can confirm this issue. It is happening with a lot of our users.

    "electron-builder": "22.11.11",
    "electron-updater": "4.4.3",

[mmaietta]

Please update to latest electron-updater to leverage this fix.