Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround vite replacing process.env in updater #6160

Merged
merged 2 commits into from Aug 22, 2021
Merged

fix: workaround vite replacing process.env in updater #6160

merged 2 commits into from Aug 22, 2021

Conversation

@pzeinlinger
Copy link
Contributor

@pzeinlinger pzeinlinger commented Aug 16, 2021

Vite replaces process.env.* during builds.
This leads to problems with the updater.

A known workaround is to replace process.env.* with process.env["*"].

vitejs/vite#3176

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Aug 16, 2021

🦋 Changeset detected

Latest commit: f0018e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Loading

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Aug 21, 2021

@pzeinlinger my main concern with this is that it'll still break in the future. I have no way to enforce or persist the knowledge for future contributors that process.env.ANY_VAR won't work for vite. I'm doubtful I'll consistently remember it tbh.

Loading

@mmaietta mmaietta merged commit a3c72b2 into electron-userland:master Aug 22, 2021
7 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants