Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): internationalize appCannotBeClosed #6277

Conversation

indutny-signal
Copy link
Contributor

appCannotBeClosed is displayed (quite prominently) when the NSIS
installer cannot proceed with the installation due to app still running
in the background. This commit translates it to several languages.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2021

🦋 Changeset detected

Latest commit: 8ac8c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for jolly-roentgen-9c9aba ready!

🔨 Explore the source changes: 8ac8c31

🔍 Inspect the deploy log: https://app.netlify.com/sites/jolly-roentgen-9c9aba/deploys/614ccc78dfabdf0007d66e80

😎 Browse the preview: https://deploy-preview-6277--jolly-roentgen-9c9aba.netlify.app

`appCannotBeClosed` is displayed (quite prominently) when the NSIS
installer cannot proceed with the installation due to app still running
in the background. This commit translates it to several languages.
@mmaietta mmaietta changed the title chore(nsis): internationalize appCannotBeClosed fix(nsis): internationalize appCannotBeClosed Sep 25, 2021
@mmaietta mmaietta merged commit b83d4ea into electron-userland:master Sep 25, 2021
@github-actions github-actions bot mentioned this pull request Sep 25, 2021
@indutny-signal indutny-signal deleted the feature/translate-nsis-message branch September 26, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants