Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quitAndInstall not working on macOS with autoInstallOnAppQuit=false #6390

Merged
merged 3 commits into from
Nov 9, 2021
Merged

fix: quitAndInstall not working on macOS with autoInstallOnAppQuit=false #6390

merged 3 commits into from
Nov 9, 2021

Commits on Nov 3, 2021

  1. Fix quitAndInstall not working on macOS with autoInstallOnAppQuit=false 

    - Would never call nativeUpdater.checkForUpdates() if not installing on
  quit. Thus neither squirrelDownloadedUpdate was true nor the
  nativeUpdater's event "update-downloaded" be emitted. Leading to
  nothing happening.

- This commit fixes it by calling the checkForUpdates() in
  MacUpdater.quitAndInstall() when necessary

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    194c286 View commit details
    Browse the repository at this point in the history

  2. Add changeset 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    35929bc View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Attach event listener before downloading 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3108cd7 View commit details
    Browse the repository at this point in the history