fix(nsis): specify full path to system's find #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIT-SCM installation can override window's native `find` command line tool with the one from unix tools. This in turn changes the exit code of the whole find process command and makes us detect the app as running even though it is not. Credit and original fix by @theAddict
🦋 Changeset detectedLatest commit: 2c42f9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for car-park-attendant-cleat-11576 failed.
|
|
cc @I-Otsuki |
|
Thanks for your contribution! |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIT-SCM installation can override window's native
findcommand linetool with the one from unix tools. This in turn changes the exit code of
the whole find process command and makes us detect the app as running
even though it is not.
Credit and original fix by @theAddict
See signalapp/Signal-Desktop#5856