Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmg-builder): exec python fail on Macos12.3 #6789

Merged
merged 3 commits into from
Apr 13, 2022
Merged

fix(dmg-builder): exec python fail on Macos12.3 #6789

merged 3 commits into from
Apr 13, 2022

Conversation

bytemain
Copy link
Contributor

close: #6767

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2022

🦋 Changeset detected

Latest commit: afbda22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
dmg-builder Patch
electron-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 12, 2022

👷 Deploy Preview for car-park-attendant-cleat-11576 processing.

Name Link
🔨 Latest commit afbda22
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62569254c689400008e0c671

@mmaietta
Copy link
Collaborator

This change is causing all mac dmg tests to fail as it's trying to use python @ /usr/local/bin/python

FAIL  src/mac/dmgTest.ts (585.119 s)
  ✕ dmg (13943 ms)

  ● dmg

    Exit code: ENOENT. spawn /usr/local/bin/python
     ENOENT

      131 |           }
      132 |
    > 133 |           reject(new Error(message))
          |                  ^
      134 |         }
      135 |       }
      136 |     )

      at ../packages/builder-util/src/util.ts:133:18

Unfortunately, github actions doesn't have a MacOS 12 build machine yet otherwise I'd be running our tests on that.

@bytemain
Copy link
Contributor Author

it seem that which python got a result: /usr/local/bin/python.

but why it does not exists

@bytemain
Copy link
Contributor Author

it seem that I have fixed it.

the return value of exec func has a '\n' suffix.

@mmaietta
Copy link
Collaborator

Thank you for your contribution!

Seems the Docs automation is frozen, but the CI tests all passed. Merging now

@mmaietta mmaietta merged commit 76f3a1d into electron-userland:master Apr 13, 2022
@bytemain bytemain deleted the fix/dmg-builder branch April 14, 2022 04:08
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Dec 12, 2022
  This is the latest version of the v23.x major version, including a fix
  to the macOS `dmg` generation, introduced in v23.0.6 (see
  electron-userland/electron-builder#6789), that
  should allow us to build on Github Actions again.
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Dec 12, 2022
  This is the latest version of the v23.x major version, including a fix
  to the macOS `dmg` generation, introduced in v23.0.6 (see
  electron-userland/electron-builder#6789), that
  should allow us to build on Github Actions again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit code: ENOENT. spawn /usr/bin/python ENOENT
2 participants