Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inappropriate electron-updater cache directory on macOS #7032

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 30, 2022

On macOS, ~/Library/Application Support is where applications persist data, and caches are stored in ~/Library/Caches.

Currently electron-updater mistakenly created its own Caches directory under ~/Library/Application Support, which is bad practice and not align with e.g. the usage of XDG_CACHE_HOME below.

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2022

🦋 Changeset detected

Latest commit: 08d3b95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 30, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 08d3b95
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6340a0f7c6d2f5000892751b
😎 Deploy Preview https://deploy-preview-7032--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
Copy link
Collaborator

Would this be a breaking change? Not sure what else relies on the Cache

@kidonng
Copy link
Contributor Author

kidonng commented Jul 31, 2022

Would this be a breaking change?

This should only affects the updater so I don't think it could break anything, it is cache anyway.

Not sure what else relies on the Cache

I'm not very familiar with electron-builder so I can't tell. But if this refers to the one under Application Support then anything else using it needs to be fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants