Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use electron/rebuild Rebuilder directly for cross-platform builds #7629

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Jun 24, 2023

fix: use electron-rebuilder API directly so as to override the platform for cross-platform prebuild compilations

Credit to debugger @cocktailpeanut in #7465

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2023

🦋 Changeset detected

Latest commit: dcdcdc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
electron-builder Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit dcdcdc2
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6497383e9272640008714dd7
😎 Deploy Preview https://deploy-preview-7629--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit 285aa76 into master Jun 24, 2023
13 checks passed
@mmaietta mmaietta deleted the fix/electron-rebuild-platform branch June 24, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant